From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQM5A-0007Bm-Rz for qemu-devel@nongnu.org; Mon, 22 Oct 2012 13:46:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQM59-000365-O5 for qemu-devel@nongnu.org; Mon, 22 Oct 2012 13:46:32 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:57213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQM59-00035r-HT for qemu-devel@nongnu.org; Mon, 22 Oct 2012 13:46:31 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Oct 2012 11:46:26 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 1C9C03E4004E for ; Mon, 22 Oct 2012 11:46:23 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9MHkKp3120312 for ; Mon, 22 Oct 2012 11:46:21 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9MHkJ18032495 for ; Mon, 22 Oct 2012 11:46:19 -0600 Message-ID: <50858666.90901@linux.vnet.ibm.com> Date: Mon, 22 Oct 2012 13:46:14 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1350914024-4794-1-git-send-email-coreyb@linux.vnet.ibm.com> <20121022141617.754fce0e@doriath.home> In-Reply-To: <20121022141617.754fce0e@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , kwolf@redhat.com Cc: gollub@b1-systems.de, qemu-devel@nongnu.org, agraf@suse.de On 10/22/2012 12:16 PM, Luiz Capitulino wrote: > On Mon, 22 Oct 2012 09:53:44 -0400 > Corey Bryant wrote: > >> >> Signed-off-by: Corey Bryant >> --- >> vl.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/vl.c b/vl.c >> index 200d849..94c667d 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque) >> return -1; >> } >> >> +#ifndef _WIN32 >> if (fcntl(fd, F_GETFD) & FD_CLOEXEC) { >> qerror_report(ERROR_CLASS_GENERIC_ERROR, >> "fd is not valid or already in use"); >> return -1; >> } >> +#endif > > Which series is this from? The command-line support for fd sets? > > qerror_report() is deprecated. > Kevin, please let me know if you want me to fix this. Otherwise I assume you'll modify the v5 patch. >> >> if (fdset_id < 0) { >> qerror_report(ERROR_CLASS_GENERIC_ERROR, > -- Regards, Corey Bryant