From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQN7w-00072y-LG for qemu-devel@nongnu.org; Mon, 22 Oct 2012 14:53:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQN7v-0005uS-Ff for qemu-devel@nongnu.org; Mon, 22 Oct 2012 14:53:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52259 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQN7v-0005uF-6W for qemu-devel@nongnu.org; Mon, 22 Oct 2012 14:53:27 -0400 Message-ID: <5085961E.8030801@suse.de> Date: Mon, 22 Oct 2012 20:53:18 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <707fd29bf6b842cb43ceec3fd81351a24309fb23.1350677362.git.jbaron@redhat.com> <50854980.2010908@suse.de> <20121022161730.GA23029@redhat.com> In-Reply-To: <20121022161730.GA23029@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, armbru@redhat.com, kraxel@redhat.com Am 22.10.2012 18:17, schrieb Michael S. Tsirkin: > On Mon, Oct 22, 2012 at 03:26:24PM +0200, Andreas F=E4rber wrote: >> Am 19.10.2012 22:43, schrieb Jason Baron: >>> create mode 100644 hw/i21154.c >>> create mode 100644 hw/i21154.h >> >> Why is this creating a new file and not reusing dec_pci.c? We shouldn'= t >> have two parallel implementations of the same chip. >=20 > Good point I missed this. There's a minor difference > wrt dec-21154-p2p-bridge in a couple of fields, > these could be set by properties. > Also dec_map_irq differs from the spec compliant > map function. I am guessing this is a bug. > Would appreciate testing of the patch below. >=20 >=20 > Are you familiar with dec_pci.c? Looking at it, it seems to > implement a pci host bridge "dec-21154-sysbus" , > a pci to pci bridge "dec-21154-p2p-bridge",=20 > and something called "dec-21154" which sports a comment > "PCI2PCI bridge same values as PearPC - check this" - > and implements an empty init function; > what this last is and why it's useful I am not sure. Apart from my PHB rework touching it, I had a branch starting to QOM'ify it. From what I remember it was a PCIDevice that interfaces with a "regular" SysBus PHB device and like most PHBs has a PCIDevice on its PCIBus. That would match the number of devices you mention, although the exact names are pretty confusing for all PHBs IMO. ;) > Anyone? Blue Swirl? Anyone can test this doesn't break > things and report? I'll look more closely and test when I'm back from oSC mid of the week. I think it was ppc_newworld that was using this, possibly subject to #if 0 (which I was trying to clean up, too). Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg