From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TQb5G-00076D-O3
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 05:47:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TQb57-0001zA-Lg
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 05:47:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34136)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TQb57-0001z4-EH
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 05:47:29 -0400
Message-ID: <508667A9.402@redhat.com>
Date: Tue, 23 Oct 2012 11:47:21 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1350914024-4794-1-git-send-email-coreyb@linux.vnet.ibm.com>
	<20121022141617.754fce0e@doriath.home>
	<50858666.90901@linux.vnet.ibm.com>
In-Reply-To: <50858666.90901@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for
	_WIN32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: agraf@suse.de, gollub@b1-systems.de, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Am 22.10.2012 19:46, schrieb Corey Bryant:
> 
> 
> On 10/22/2012 12:16 PM, Luiz Capitulino wrote:
>> On Mon, 22 Oct 2012 09:53:44 -0400
>> Corey Bryant <coreyb@linux.vnet.ibm.com> wrote:
>>
>>>
>>> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
>>> ---
>>>   vl.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/vl.c b/vl.c
>>> index 200d849..94c667d 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
>>>           return -1;
>>>       }
>>>
>>> +#ifndef _WIN32
>>>       if (fcntl(fd, F_GETFD) & FD_CLOEXEC) {
>>>           qerror_report(ERROR_CLASS_GENERIC_ERROR,
>>>                         "fd is not valid or already in use");
>>>           return -1;
>>>       }
>>> +#endif
>>
>> Which series is this from? The command-line support for fd sets?
>>
>> qerror_report() is deprecated.
>>
> 
> Kevin, please let me know if you want me to fix this.  Otherwise I 
> assume you'll modify the v5 patch.

Any conversion of interfaces should be done on top.

Kevin