From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TQcjM-0005WR-Jo
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 07:33:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TQcjE-0007ow-As
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 07:33:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16946)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TQcjE-0007oV-3M
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 07:33:00 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9NBWwvV014546
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 23 Oct 2012 07:32:58 -0400
Message-ID: <50868067.8060206@redhat.com>
Date: Tue, 23 Oct 2012 13:32:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1350653528-5834-1-git-send-email-pbonzini@redhat.com>
	<1350653528-5834-15-git-send-email-pbonzini@redhat.com>
	<87vce2bj6s.fsf@blackfin.pond.sub.org>
In-Reply-To: <87vce2bj6s.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/29] vnc: introduce a single label for
 error returns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

Il 22/10/2012 17:49, Markus Armbruster ha scritto:
>>          }
>> >          if (vs->lsock < 0) {
>> >              g_free(dpy);
>> > -            return -1;
>> > +            goto fail;
> Now additionally executes
> 
>        g_free(vs->display);
>        vs->display = NULL;
> 
> Silent bug fix?
> 

Possibly... no idea how to reproduce it.

Paolo