From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TQdgf-0000GT-AT
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:34:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TQdgV-00026V-Eh
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:34:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TQdgV-00026E-6J
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:34:15 -0400
Message-ID: <50868EC4.7050205@redhat.com>
Date: Tue, 23 Oct 2012 14:34:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1350653528-5834-1-git-send-email-pbonzini@redhat.com>
	<87k3uigu6x.fsf@codemonkey.ws>
In-Reply-To: <87k3uigu6x.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD
 server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

Il 22/10/2012 21:53, Anthony Liguori ha scritto:
>   LINK  vscclient
> qemu-tool.o: In function `monitor_get_fd':
> /home/anthony/git/qemu/qemu-tool.c:53: undefined reference to `error_set'
> collect2: ld returned 1 exit status
> make: *** [vscclient] Error 1
> 
> Even tried a clean build and get the same error.

Fixed like this and pushed to the same place (tip is now commit
8b5c3381d28ebb1765f17a4cbe1852d3b68b7dc4).  Sorry.

I will try to clean up the dependencies before or during soft feature
freeze.

Paolo

diff --git a/Makefile b/Makefile
index 88285a4..2a33868 100644
--- a/Makefile
+++ b/Makefile
@@ -171,7 +171,8 @@ qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y) $(block-obj-y)
 
 qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o
 
-vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) $(trace-obj-y) $(tools-obj-y) qemu-timer-common.o libcacard/vscclient.o
+vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) $(trace-obj-y) \
+	error.o $(tools-obj-y) qemu-timer-common.o libcacard/vscclient.o
 	$(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(libcacard_libs) $(LIBS),"  LINK  $@")
 
 fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o oslib-posix.o $(trace-obj-y)