From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQf7x-0005lN-Mo for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:06:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQf7l-0006Jc-UM for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:06:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQf7l-0006JL-Lr for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:06:29 -0400 Message-ID: <5086A45F.8000608@redhat.com> Date: Tue, 23 Oct 2012 16:06:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1350988210-1318-1-git-send-email-avi@redhat.com> <878vaxs5z4.fsf@codemonkey.ws> In-Reply-To: <878vaxs5z4.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Avi Kivity , qemu-devel@nongnu.org Il 23/10/2012 14:55, Anthony Liguori ha scritto: >> > target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are >> > reserved) and its purpose doesn't match the name (most target_phys_addr_t >> > addresses are not target specific). Replace it with a finger-friendly, >> > standards conformant hwaddr. >> > >> > Outstanding patchsets can be fixed up with the command >> > >> > git rebase -i --exec 'find -name "*.[ch]" >> > | xargs s/target_phys_addr_t/hwaddr/g' origin > We're getting pretty close to soft freeze so perhaps it's time to make a > couple big changes. > > Paolo, are you ready to do the file rename changes? I'd like to > coordinate this change with that one and do it all at the same time. BTW, $ git diffstat -M20 -C20 -l1500 --find-copies-harder origin/master.. | tail -1 1084 files changed, 4120 insertions(+), 5692 deletions(-) (mostly due to moving around the include files, which is scripted). $ git format-series -M20 -C20 -l1500 --find-copies-harder origin/master.. | wc -l 35346 Paolo