From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr
Date: Tue, 23 Oct 2012 16:50:31 +0200 [thread overview]
Message-ID: <5086AEB7.8010400@redhat.com> (raw)
In-Reply-To: <CAFEAcA9NXZ=T2Jf3xvLoRvccTbY1TKKBpHn4XApXSEGZLMe+MA@mail.gmail.com>
On 10/23/2012 03:04 PM, Peter Maydell wrote:
> On 23 October 2012 11:30, Avi Kivity <avi@redhat.com> wrote:
>> target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
>> reserved) and its purpose doesn't match the name (most target_phys_addr_t
>> addresses are not target specific). Replace it with a finger-friendly,
>> standards conformant hwaddr.
>>
>> Outstanding patchsets can be fixed up with the command
>>
>> git rebase -i --exec 'find -name "*.[ch]"
>> | xargs s/target_phys_addr_t/hwaddr/g' origin
>
> Isn't this command line missing a "sed" or something?
Yes.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-10-23 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 10:30 [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr Avi Kivity
2012-10-23 12:55 ` Anthony Liguori
2012-10-23 12:59 ` Paolo Bonzini
2012-10-23 14:06 ` Paolo Bonzini
2012-10-23 14:52 ` Avi Kivity
2012-10-23 13:04 ` Peter Maydell
2012-10-23 14:50 ` Avi Kivity [this message]
2012-10-23 18:11 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086AEB7.8010400@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).