From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQfoZ-0002pt-OX for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:50:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQfoV-00028y-Ni for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:50:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQfoV-00028P-Fq for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:50:39 -0400 Message-ID: <5086AEB7.8010400@redhat.com> Date: Tue, 23 Oct 2012 16:50:31 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1350988210-1318-1-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , qemu-devel@nongnu.org, Anthony Liguori On 10/23/2012 03:04 PM, Peter Maydell wrote: > On 23 October 2012 11:30, Avi Kivity wrote: >> target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are >> reserved) and its purpose doesn't match the name (most target_phys_addr_t >> addresses are not target specific). Replace it with a finger-friendly, >> standards conformant hwaddr. >> >> Outstanding patchsets can be fixed up with the command >> >> git rebase -i --exec 'find -name "*.[ch]" >> | xargs s/target_phys_addr_t/hwaddr/g' origin > > Isn't this command line missing a "sed" or something? Yes. -- error compiling committee.c: too many arguments to function