From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59070)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TQfqy-0003mj-CR
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:53:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TQfqs-00039J-GC
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:53:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TQfqs-00038o-7v
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 10:53:06 -0400
Message-ID: <5086AF4A.4010201@redhat.com>
Date: Tue, 23 Oct 2012 16:52:58 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1350988210-1318-1-git-send-email-avi@redhat.com>
	<878vaxs5z4.fsf@codemonkey.ws>
In-Reply-To: <878vaxs5z4.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 10/23/2012 02:55 PM, Anthony Liguori wrote:
> Avi Kivity <avi@redhat.com> writes:
> 
>> target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
>> reserved) and its purpose doesn't match the name (most target_phys_addr_t
>> addresses are not target specific).  Replace it with a finger-friendly,
>> standards conformant hwaddr.
>>
>> Outstanding patchsets can be fixed up with the command
>>
>>   git rebase -i --exec 'find -name "*.[ch]"
>>                         | xargs s/target_phys_addr_t/hwaddr/g' origin
> 
> We're getting pretty close to soft freeze so perhaps it's time to make a
> couple big changes.
> 
> Paolo, are you ready to do the file rename changes?  I'd like to
> coordinate this change with that one and do it all at the same time.

Is there really any need to coordinate?  While this patch will cause
some rebasing, it is fairly trivial, even if you don't use the sedless
command above.


-- 
error compiling committee.c: too many arguments to function