From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQgTD-0001qC-2R for qemu-devel@nongnu.org; Tue, 23 Oct 2012 11:32:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQgT7-0007aY-Ak for qemu-devel@nongnu.org; Tue, 23 Oct 2012 11:32:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQgT6-0007aE-W8 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 11:32:37 -0400 Message-ID: <5086B88F.7060400@redhat.com> Date: Tue, 23 Oct 2012 09:32:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350995029-29128-1-git-send-email-benoit@irqsave.net> <1350995029-29128-4-git-send-email-benoit@irqsave.net> In-Reply-To: <1350995029-29128-4-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig27AD5E9565FCF2224289A9A9" Subject: Re: [Qemu-devel] [PATCH 03/11] quorum: Add quorum_open() and quorum_close(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig27AD5E9565FCF2224289A9A9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/23/2012 06:23 AM, Beno=C3=AEt Canet wrote: > Valid quorum resources look like > quorum:threshold/total:path/to/image_1: ... :path/to/image_total >=20 > ':' is used as a separator to allow to use networked path > '\' is the escaping character for filename containing ':' > '\' escape itself >=20 > On the command line for quorum files "img,test.raw", "img2.raw" Here, you used a comma, > and "img3.raw" invocation look like: >=20 > -drive file=3Dquorum:2/3:img\\:test.raw:img2.raw:img3.raw but here, you are using a colon for the underlying name 'img:test.raw'. > (note the double \\) You also didn't give an example of comma escaping using typical command line comma escaping; but at least your example looks okay once you fix the typo in the lead-in text. The code appears to match the commit messa= ge. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig27AD5E9565FCF2224289A9A9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQhriPAAoJEKeha0olJ0NqHjsIAJy1qk5/2WpkSgJ7OAJuVChf yrGNSQ1LglNkV3J42AV4jjtcQxhRibPwQ7NrCCBcHkkFXXON6QJffFBpIE1Q416n FxfQKSu7sZWK5WPeUrycF4k2JdpHVhuhr1cD1HB1fzwiLpRmdV0pMZH48xzOHOWr hASxtEynV/Ek2TBHdsFpXAzi7prbQ9Ri1XkUAsE5OlTxPpXouwrr/1gLfvNvCDZw ++YIGhIp6slNGjENY+hBAh5xDmN1yaZWjQQ1DPzWNfJZC3TaOk60CuR+bShPX/1K rOfcSPE9HhXbADUUM/CAs6s/wWeDiXp7hs8E0JdkRyaF8lexqsmo6Pwp7uTSXEE= =V3Bp -----END PGP SIGNATURE----- --------------enig27AD5E9565FCF2224289A9A9--