From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit@irqsave.net>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 06/11] quorum: Add quorum_co_flush().
Date: Tue, 23 Oct 2012 09:37:21 -0600 [thread overview]
Message-ID: <5086B9B1.1090901@redhat.com> (raw)
In-Reply-To: <1350995029-29128-7-git-send-email-benoit@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
On 10/23/2012 06:23 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
> block/quorum.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 878d930..1b40081 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -281,6 +281,18 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriverState *bs,
> return &acb->common;
> }
>
> +static coroutine_fn int quorum_co_flush(BlockDriverState *bs)
> +{
> + BDRVQuorumState *s = bs->opaque;
> + int i;
> +
> + for (i = 0; i < s->total; i++) {
> + bdrv_co_flush(s->bs[i]);
What if any of the individual flush calls return non-zero?
> + }
> +
> + return 0;
Shouldn't you then do likewise?
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-23 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 12:23 [Qemu-devel] [PATCH 00/11] Quorum disk image corruption resiliency Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 03/11] quorum: Add quorum_open() and quorum_close() Benoît Canet
2012-10-23 15:32 ` Eric Blake
2012-10-23 12:23 ` [Qemu-devel] [PATCH 04/11] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 06/11] quorum: Add quorum_co_flush() Benoît Canet
2012-10-23 15:37 ` Eric Blake [this message]
2012-10-23 12:23 ` [Qemu-devel] [PATCH 07/11] quorum: Add quorum_aio_readv Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 08/11] quorum: Add quorum mechanism Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 09/11] quorum: Add quorum_getlength() Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 10/11] quorum: Add quorum_invalidate_cache() Benoît Canet
2012-10-23 12:23 ` [Qemu-devel] [PATCH 11/11] quorum: Add quorum_co_is_allocated Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086B9B1.1090901@redhat.com \
--to=eblake@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).