From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQgXr-0004LP-QG for qemu-devel@nongnu.org; Tue, 23 Oct 2012 11:37:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQgXl-0001aU-QH for qemu-devel@nongnu.org; Tue, 23 Oct 2012 11:37:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQgXl-0001aH-Gz for qemu-devel@nongnu.org; Tue, 23 Oct 2012 11:37:25 -0400 Message-ID: <5086B9B1.1090901@redhat.com> Date: Tue, 23 Oct 2012 09:37:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350995029-29128-1-git-send-email-benoit@irqsave.net> <1350995029-29128-7-git-send-email-benoit@irqsave.net> In-Reply-To: <1350995029-29128-7-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigC9D378AA73CB58E53A71677B" Subject: Re: [Qemu-devel] [PATCH 06/11] quorum: Add quorum_co_flush(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC9D378AA73CB58E53A71677B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/23/2012 06:23 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/block/quorum.c b/block/quorum.c > index 878d930..1b40081 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -281,6 +281,18 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDr= iverState *bs, > return &acb->common; > } > =20 > +static coroutine_fn int quorum_co_flush(BlockDriverState *bs) > +{ > + BDRVQuorumState *s =3D bs->opaque; > + int i; > + > + for (i =3D 0; i < s->total; i++) { > + bdrv_co_flush(s->bs[i]); What if any of the individual flush calls return non-zero? > + } > + > + return 0; Shouldn't you then do likewise? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigC9D378AA73CB58E53A71677B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQhrmxAAoJEKeha0olJ0NqadwIAJWTTFX1u6Ug7l2ptvr2X/oU veo7ylUp+M7nfby/iZUEllV9BVQLAwYMMiZLu7eMw8pwiQ7eVrZeY4gK/wOk9w2u 2Ij9RF5uOZb/5ajDv/RjGpMYV2TWLthGLlwANmmijOryzGqbiWO8QPmpwFOYUHHz D2HYrPu+6pAt9j63Ck6sdKupdXa7SJubG8SjNPBD/OpGt0W+rYoltbfypBJQxM9/ LJ5EXH76sSkTwXdktCkfWyrl1vDUVUsi4VCNSbCgnP6b9FAQjV2Io+8EXlY0A7Tx 5OOyOcdDYJ1d81bI1h0VQ0XPT1HZUmzA5VarOdcX3Gp0SE/3sQiDZxSA50E/LdI= =KvIN -----END PGP SIGNATURE----- --------------enigC9D378AA73CB58E53A71677B--