From: Eric Blake <eblake@redhat.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: pmoore@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
Eduardo Otubo <otubo@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCHv2 4/4] Warning messages on net devices hotplug
Date: Tue, 23 Oct 2012 10:39:22 -0600 [thread overview]
Message-ID: <5086C83A.5000804@redhat.com> (raw)
In-Reply-To: <5086BEF4.7090101@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On 10/23/2012 09:59 AM, Corey Bryant wrote:
> Only network devices are prevented, right?
>
> Also, as I mentioned before, can you limit this to the subset of options
> that cause execve() to be issued? For example, can we allow libvirt to
> pass an fd for hotplugging a network device (e.g. netdev_add tap,fd=23)?
> I don't know for sure but I'm guessing libvirt does that.
Correct, libvirt prefers passing network devices pre-opened via fds,
rather than having qemu exec scripts.
>> + manual. Also note that the hot plug is disabled when -sandbox
>> is in
>> + effect
>
> Not all hotplug abilities are disabled. Just network devices. This is
> missing a period too.
And not all network hotplug, just hotplug that requires use of exec
(again, fd passing bypasses the need for exec).
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-23 16:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 5:55 [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162) Eduardo Otubo
2012-10-23 5:55 ` [Qemu-devel] [PATCHv2 2/4] Setting "-sandbox on" as deafult Eduardo Otubo
2012-10-23 5:55 ` [Qemu-devel] [PATCHv2 3/4] Support for "double whitelist" filters Eduardo Otubo
2012-10-23 15:10 ` Corey Bryant
2012-10-24 20:06 ` Eduardo Otubo
2012-10-25 20:16 ` Eduardo Otubo
2012-11-02 21:29 ` Paul Moore
2012-11-02 22:00 ` Corey Bryant
2012-11-02 22:14 ` Paul Moore
2012-11-05 14:39 ` Corey Bryant
2012-11-05 21:58 ` Paul Moore
2012-11-05 22:26 ` Corey Bryant
2012-11-02 22:01 ` Anthony Liguori
2012-10-23 5:55 ` [Qemu-devel] [PATCHv2 4/4] Warning messages on net devices hotplug Eduardo Otubo
2012-10-23 15:59 ` Corey Bryant
2012-10-23 16:39 ` Eric Blake [this message]
2012-11-01 21:43 ` [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162) Paul Moore
2012-11-02 2:29 ` Eduardo Otubo
2012-11-02 14:10 ` Paul Moore
2012-11-02 13:48 ` Corey Bryant
2012-11-02 14:10 ` Paul Moore
2012-11-02 14:38 ` Paul Moore
2012-11-02 14:43 ` Corey Bryant
2012-11-02 14:46 ` Paul Moore
2012-11-02 14:49 ` Corey Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086C83A.5000804@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=otubo@linux.vnet.ibm.com \
--cc=pmoore@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).