From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQhWH-00013w-Va for qemu-devel@nongnu.org; Tue, 23 Oct 2012 12:39:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQhW7-0003iM-UD for qemu-devel@nongnu.org; Tue, 23 Oct 2012 12:39:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQhW7-0003hi-LB for qemu-devel@nongnu.org; Tue, 23 Oct 2012 12:39:47 -0400 Message-ID: <5086C83A.5000804@redhat.com> Date: Tue, 23 Oct 2012 10:39:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350971732-16621-1-git-send-email-otubo@linux.vnet.ibm.com> <1350971732-16621-4-git-send-email-otubo@linux.vnet.ibm.com> <5086BEF4.7090101@linux.vnet.ibm.com> In-Reply-To: <5086BEF4.7090101@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigFCA3BA6271DA6925DCB5C8B9" Subject: Re: [Qemu-devel] [PATCHv2 4/4] Warning messages on net devices hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: pmoore@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, Eduardo Otubo This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFCA3BA6271DA6925DCB5C8B9 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/23/2012 09:59 AM, Corey Bryant wrote: > Only network devices are prevented, right? >=20 > Also, as I mentioned before, can you limit this to the subset of option= s > that cause execve() to be issued? For example, can we allow libvirt to= > pass an fd for hotplugging a network device (e.g. netdev_add tap,fd=3D2= 3)? > I don't know for sure but I'm guessing libvirt does that. Correct, libvirt prefers passing network devices pre-opened via fds, rather than having qemu exec scripts. >> + manual. Also note that the hot plug is disabled when -sandbox >> is in >> + effect >=20 > Not all hotplug abilities are disabled. Just network devices. This is= > missing a period too. And not all network hotplug, just hotplug that requires use of exec (again, fd passing bypasses the need for exec). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigFCA3BA6271DA6925DCB5C8B9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQhsg6AAoJEKeha0olJ0NqCKgH/iu3bv1OPpfYB3mzI1fdo2Cj KDtrJteTfwP2bE4a/vkOwqUROJ1Qnpmg3wB2/XOI78skuyp0Qzrgmu3WhhU0Z7ET l+MNEjF9WpG7Jyjxe/FNO68O2rRlJgAMvRGZyj8MzPxhvNXRCQjNdH088OOq374i j+y3n1NTfy0pr9lMoR9awmJUzBO37vAyx7SPPkkODh9zsC8wEgIuUwnBBpXYbrtp mnPT1ZS3PhU8EohGqhsE29jknGYUxHUzJpOaU/+d2i/698tFHfatE+oy9cHf2DKs H1U6yTb1AuvlzH1fjRTsl+fza2hmc7ONQ5hT+0mmn2csRLJL3E1E9vJTEZFUmFI= =LqE1 -----END PGP SIGNATURE----- --------------enigFCA3BA6271DA6925DCB5C8B9--