From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQqDj-00044K-3N for qemu-devel@nongnu.org; Tue, 23 Oct 2012 21:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQqDh-0006ea-H5 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 21:57:23 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:46840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQqDg-0006dK-8V for qemu-devel@nongnu.org; Tue, 23 Oct 2012 21:57:21 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Oct 2012 11:53:53 +1000 Message-ID: <50874AED.7090200@linux.vnet.ibm.com> Date: Wed, 24 Oct 2012 07:27:01 +0530 From: Avik Sil MIME-Version: 1.0 References: <1350986975-21786-1-git-send-email-aviksil@linux.vnet.ibm.com> <1350986975-21786-2-git-send-email-aviksil@linux.vnet.ibm.com> <1A23CBFB-5BF8-45A3-A7FB-9E00E6D18AA1@suse.de> <20121023224351.GE13231@truffula.fritz.box> <20121023234315.GG13231@truffula.fritz.box> In-Reply-To: <20121023234315.GG13231@truffula.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aliguori@us.ibm.com, qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org On 10/24/2012 05:13 AM, David Gibson wrote: > On Wed, Oct 24, 2012 at 12:47:34AM +0200, Alexander Graf wrote: >> >> On 24.10.2012, at 00:43, David Gibson wrote: >> >>> On Tue, Oct 23, 2012 at 12:20:08PM +0200, Alexander Graf wrote: >>>> >>>> On 23.10.2012, at 12:09, Avik Sil wrote: >>>> >>>>> This patch makes default boot order machine specific instead of >>>>> set globally. The default boot order can be set per machine in >>>>> QEMUMachine default_machine_opts, or by the command line using >>>>> -machine ,boot=, or by standard -boot >>>>> option. This allows a machine to receive a NULL boot order when >>>>> -boot isn't used and take an appropriate action accordingly. This >>>>> helps machine boots from the devices as set in guest's non-volatile >>>>> memory location in case no boot order is provided by the user. >>>>> >>>>> Signed-off-by: Avik Sil >>>>> --- >>>>> hw/nseries.c | 2 ++ >>>>> hw/pc_piix.c | 13 ++++++++++++- >>>>> hw/ppc_newworld.c | 1 + >>>>> hw/ppc_oldworld.c | 1 + >>>>> hw/ppc_prep.c | 1 + >>>>> hw/sun4m.c | 10 ++++++++++ >>>>> hw/sun4u.c | 3 +++ >>>> >>>> That feels like too much magic for my taste. Can't we have some >>>> default macro (or even the explicit "cad" thing) that we push to >>>> _every_ machine description out there? The next patch to implement >>>> boot= for pseries would then remove this default value for the >>>> pseries machine. >>> >>> I'm not 100% clear on what you mean here. Do you just mean: >>> #define DEFAULT_BOOT_ORDER "boot=cad" >>> and then we use >>> .default_machine_opts = DEFAULT_BOOT_ORDER, >>> >>> or something else? >> >> I mean that this patch only patches 7 files. Check this out: > > Oh, yes, oops. Saw the big pile of hunks changing machines and > assumed that was all, but in fact half of them were just the PC > variants. > > Avik, this will need to be fixed. > Sure, will do. Actually I patched the machines that do care for boot order like in pc_piix.c and other machines do not care for the order. But in next series I'll do it for every machine. Regards, Avik