From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQqHj-0005EA-KE for qemu-devel@nongnu.org; Tue, 23 Oct 2012 22:01:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQqHi-0007sp-6F for qemu-devel@nongnu.org; Tue, 23 Oct 2012 22:01:31 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:53449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQqHh-0007sI-J3 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 22:01:30 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Oct 2012 12:00:37 +1000 Message-ID: <50874BEF.8050604@linux.vnet.ibm.com> Date: Wed, 24 Oct 2012 07:31:19 +0530 From: Avik Sil MIME-Version: 1.0 References: <1350986975-21786-1-git-send-email-aviksil@linux.vnet.ibm.com> <1350986975-21786-3-git-send-email-aviksil@linux.vnet.ibm.com> <20121023224518.GF13231@truffula.fritz.box> In-Reply-To: <20121023224518.GF13231@truffula.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: set boot-device property only if boot order specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aliguori@us.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 10/24/2012 04:15 AM, David Gibson wrote: > On Tue, Oct 23, 2012 at 03:39:35PM +0530, Avik Sil wrote: >> Signed-off-by: Avik Sil > > As Anthony suggests, it would be better to explicitly remove the > normal default boot order in this patch, after adding it for > absolutely everything in the first patch. > > This also needs a better patch comment, explaining the significance of > the presence/absence of the property on firmware behaviour. > Sure. Shall I make the boot order for pseries as NULL string or empty string? Current patch handles NULL string. Regards, Avik >> --- >> hw/spapr.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/hw/spapr.c b/hw/spapr.c >> index 637b3fb..1b2340c 100644 >> --- a/hw/spapr.c >> +++ b/hw/spapr.c >> @@ -283,7 +283,9 @@ static void *spapr_create_fdt_skel(const char *cpu_model, >> >> _FDT((fdt_property(fdt, "qemu,boot-kernel", &kprop, sizeof(kprop)))); >> } >> - _FDT((fdt_property_string(fdt, "qemu,boot-device", boot_device))); >> + if (boot_device) { >> + _FDT((fdt_property_string(fdt, "qemu,boot-device", boot_device))); >> + } >> _FDT((fdt_property_cell(fdt, "qemu,graphic-width", graphic_width))); >> _FDT((fdt_property_cell(fdt, "qemu,graphic-height", graphic_height))); >> _FDT((fdt_property_cell(fdt, "qemu,graphic-depth", graphic_depth))); >