From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR1Yx-0001WO-MQ for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:04:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR1Yq-0005UX-08 for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:04:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR1Yp-0005TE-O1 for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:03:55 -0400 Message-ID: <5087F53E.6050705@redhat.com> Date: Wed, 24 Oct 2012 16:03:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5086728B.1010809@redhat.com> <1350990519.16343.255.camel@eboracum.office.bytemark.co.uk> <20121023150225.GB17080@jl-vm1.vm.bytemark.co.uk> <1351080994.16343.293.camel@eboracum.office.bytemark.co.uk> In-Reply-To: <1351080994.16343.293.camel@eboracum.office.bytemark.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nicholas Thomas Cc: Kevin Wolf , qemu-devel@nongnu.org Il 24/10/2012 14:16, Nicholas Thomas ha scritto: > > I've also just noticed that flush & discard don't take the send_mutex > before writing to the socket. That can't be intentional, surely? Paolo? No, it's a bug. Paolo