From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR1fN-0007Ux-6W for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR1fI-0007Tm-3S for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:10:41 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:55424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR1fH-0007SA-SZ for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:10:36 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so1182181pbb.4 for ; Wed, 24 Oct 2012 07:10:35 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5087F6D4.9030601@redhat.com> Date: Wed, 24 Oct 2012 16:10:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5086728B.1010809@redhat.com> <1350990519.16343.255.camel@eboracum.office.bytemark.co.uk> <20121023150225.GB17080@jl-vm1.vm.bytemark.co.uk> <1351080994.16343.293.camel@eboracum.office.bytemark.co.uk> <5087F53E.6050705@redhat.com> In-Reply-To: <5087F53E.6050705@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Nicholas Thomas Il 24/10/2012 16:03, Paolo Bonzini ha scritto: > Il 24/10/2012 14:16, Nicholas Thomas ha scritto: >> >> I've also just noticed that flush & discard don't take the send_mutex >> before writing to the socket. That can't be intentional, surely? Paolo? > > No, it's a bug. Hmm, why do you say it doesn't take the mutex? nbd_co_flush and nbd_co_discard all call nbd_co_send_request, which takes the mutex. Paolo