From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Blue Swirl <blauwirbel@gmail.com>,
Bruce Rogers <brogers@suse.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection
Date: Wed, 24 Oct 2012 19:20:15 +0200 [thread overview]
Message-ID: <5088234F.5050303@suse.de> (raw)
In-Reply-To: <CAFEAcA83KM8tMuT3_dtqvmvLKRi-upmR_B6XyPACsS5DF_nr1Q@mail.gmail.com>
Am 24.10.2012 18:48, schrieb Peter Maydell:
> Ping! Just ran into this bug today and noticed this
> patch never got applied.
> Patch still applies OK, patchwork url is:
> http://patchwork.ozlabs.org/patch/178920/
...and since it was noticed while packaging v1.2, it should go into
stable as well (cc'ed).
Andreas
> On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote:
>> When building qemu-kvm for openSUSE:Factory, I am getting a
>> warning in the pipe2 detection performed by configure, which
>> prevents using --enable-werror.
>>
>> Change detection code to use return value of pipe2.
>>
>> Signed-off-by: Bruce Rogers <brogers@suse.com>
>> ---
>> configure | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 5808764..2e1f7f8 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF
>> int main(void)
>> {
>> int pipefd[2];
>> - pipe2(pipefd, O_CLOEXEC);
>> - return 0;
>> + return pipe2(pipefd, O_CLOEXEC);
>> }
>> EOF
>> if compile_prog "" "" ; then
>> --
>> 1.7.7
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-10-24 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 18:45 [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection Bruce Rogers
2012-08-20 19:40 ` Peter Maydell
2012-10-24 16:48 ` Peter Maydell
2012-10-24 17:20 ` Andreas Färber [this message]
2012-10-27 16:52 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5088234F.5050303@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=brogers@suse.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).