From: Eric Blake <eblake@redhat.com>
To: Dietmar Maurer <dietmar@proxmox.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] raltelimit bug
Date: Wed, 24 Oct 2012 17:24:33 -0600 [thread overview]
Message-ID: <508878B1.6030503@redhat.com> (raw)
In-Reply-To: <24E144B8C0207547AD09C467A8259F75576FED43@lisa.maurer-it.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 10/24/2012 02:56 AM, Dietmar Maurer wrote:
> The code to compute slice_quota seems buggy. The following fixes the issue:
>
> --- new.orig/include/qemu/ratelimit.h 2012-10-22 07:06:31.000000000 +0200
Missing a Signed-off-By, so it cannot be taken as-is. See
http://wiki.qemu.org/Contribute/SubmitAPatch for hints.
> +++ new/include/qemu/ratelimit.h 2012-10-22 07:06:49.000000000 +0200
> @@ -42,7 +42,7 @@
> uint64_t slice_ns)
> {
> limit->slice_ns = slice_ns;
> - limit->slice_quota = ((double)speed * 1000000000ULL) / slice_ns;
> + limit->slice_quota = ((double)speed * slice_ns)/1000000000ULL;
> }
>
> #endif
>
>
>
>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
prev parent reply other threads:[~2012-10-24 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 8:56 [Qemu-devel] raltelimit bug Dietmar Maurer
2012-10-24 9:28 ` Paolo Bonzini
2012-10-24 23:24 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508878B1.6030503@redhat.com \
--to=eblake@redhat.com \
--cc=dietmar@proxmox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).