From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRAOL-0003sH-TI for qemu-devel@nongnu.org; Wed, 24 Oct 2012 19:29:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRAOK-0001Dd-V0 for qemu-devel@nongnu.org; Wed, 24 Oct 2012 19:29:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRAOK-0001DV-LU for qemu-devel@nongnu.org; Wed, 24 Oct 2012 19:29:40 -0400 Message-ID: <508879DF.4050300@redhat.com> Date: Wed, 24 Oct 2012 17:29:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1351073447-643298-1-git-send-email-dietmar@proxmox.com> In-Reply-To: <1351073447-643298-1-git-send-email-dietmar@proxmox.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig5D86911C4FA0F34C7A512C6C" Subject: Re: [Qemu-devel] [PATCH] stream: fix ratelimit_set_speed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dietmar Maurer Cc: pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5D86911C4FA0F34C7A512C6C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/24/2012 04:10 AM, Dietmar Maurer wrote: > The formula to compute slice_quota was wrong. >=20 > Signed-off-by: Dietmar Maurer > --- > include/qemu/ratelimit.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Eric Blake However, it might also be nice to point to the commit introducing the bug in the commit message (6ef228fc0de) >=20 > diff --git a/include/qemu/ratelimit.h b/include/qemu/ratelimit.h > index c6ac281..d1610f1 100644 > --- a/include/qemu/ratelimit.h > +++ b/include/qemu/ratelimit.h > @@ -42,7 +42,7 @@ static inline void ratelimit_set_speed(RateLimit *lim= it, uint64_t speed, > uint64_t slice_ns) > { > limit->slice_ns =3D slice_ns; > - limit->slice_quota =3D ((double)speed * 1000000000ULL) / slice_ns;= > + limit->slice_quota =3D ((double)speed * slice_ns)/1000000000ULL; > } > =20 > #endif >=20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig5D86911C4FA0F34C7A512C6C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQiHngAAoJEKeha0olJ0NqpQQH/0M24gW8pApHYrd8Z/NxoV4j Uw2bdOwF8LK8xVHUFJ75EUP8qIiVp+xlCC5/Fe7vSQWni1JG6g31WeBelbgXvtVq u++5RkQ9uc5jgb4nS9tG2ZgpqvxJOhnxWAsVU3rdEjAwWv8oTg29R9QjxqdKnXNT 7u5i8XDL0Su9+KyqIxl/1HODJxH1EmoTqH9j8i0QBg/H0jSu0vSMci1LAgAU/MHW DadgwwVsaKLQJ4vlwiIzIZ68viupSeCjVBtk+M9oNqE6Kkmp6cR+41GgyJCtQFKw 5q3492fyNwDFnh44LmMap/1Wqg7sTkV+z0+RnZ6yAIKbY4rixAaw7CIvevCsneo= =k7WP -----END PGP SIGNATURE----- --------------enig5D86911C4FA0F34C7A512C6C--