From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRJGF-0001wE-Le for qemu-devel@nongnu.org; Thu, 25 Oct 2012 04:58:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRJGE-0008Dx-PE for qemu-devel@nongnu.org; Thu, 25 Oct 2012 04:57:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRJGE-0008Dt-HF for qemu-devel@nongnu.org; Thu, 25 Oct 2012 04:57:54 -0400 Message-ID: <5088FF0C.90308@redhat.com> Date: Thu, 25 Oct 2012 10:57:48 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1350897839-29593-1-git-send-email-pingfank@linux.vnet.ibm.com> <1350897839-29593-8-git-send-email-pingfank@linux.vnet.ibm.com> <508689B0.5060904@siemens.com> <50868F34.2030505@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [patch v4 07/16] memory: make mmio dispatch able to be out of biglock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liu ping fan Cc: Jan Kiszka , Marcelo Tosatti , "qemu-devel@nongnu.org" , Anthony Liguori , Stefan Hajnoczi , Paolo Bonzini On 10/24/2012 08:56 AM, liu ping fan wrote: >>> >> Oh, here is a bug, need unref. As to unbalanced refcount, it will be >> adopted for virtio-blk listener (not implement in this patchset) >> > It is like cpu_physical_memory_map/unmap, the map will hold the > unbalanced ref, and unmap release it. Those APIs have symmetric names. map/unmap, ref/unref, lock/unlock. But here we have lookup and no unlookup. -- error compiling committee.c: too many arguments to function