From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRMGb-0002HY-Fi
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:10:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRMGV-0006my-BI
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:10:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51090)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRMGV-0006mW-3V
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:10:23 -0400
Message-ID: <50892C21.4020400@redhat.com>
Date: Thu, 25 Oct 2012 14:10:09 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1351157627.git.peter.crosthwaite@xilinx.com>
	<ea740ca8be71158d5d5e58e79a16b5a0cba692d1.1351157627.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <ea740ca8be71158d5d5e58e79a16b5a0cba692d1.1351157627.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 4/8] usb/ehci: Add usb-ehci-sysbus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: vineshp@xilinx.com, edgar.iglesias@gmail.com, john.williams@xilinx.com, qemu-devel@nongnu.org, peter.maydell@linaro.org

>  typedef struct EHCIItfState {
> -    PCIDevice pcidev;
> +    /* FIXME: Figure out a better way to share one Property[] array between two
> +     * QOM types with different parents
> +     */
> +    union {
> +        PCIDevice pcidev;
> +        SysBusDevice busdev;
> +    };

Ah, I see where this hack comes from.  I don't think they should share
the properties in the first place ...

cheers,
  Gerd