From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRMIp-0003mC-Hh
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:12:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRMIh-0007Ih-Tj
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:12:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48062)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRMIh-0007IY-M0
	for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:12:39 -0400
Message-ID: <50892CB0.6020706@redhat.com>
Date: Thu, 25 Oct 2012 14:12:32 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1351157627.git.peter.crosthwaite@xilinx.com>
	<e47518863bca237dd485619a6812d5df31ce16db.1351157627.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <e47518863bca237dd485619a6812d5df31ce16db.1351157627.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 5/8] xilinx_zynq: add USB controllers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: vineshp@xilinx.com, edgar.iglesias@gmail.com, john.williams@xilinx.com, qemu-devel@nongnu.org, peter.maydell@linaro.org

> +static inline void zynq_init_usb(uint32_t base_addr, qemu_irq irq)
> +{
> +    DeviceState *dev = qdev_create(NULL, "ehci-sysbus");

I'd suggest to have a "ehci-sysbus-zynq" device instead which sets
capsbase & opregbase in ->init() ...

> +    qdev_prop_set_uint16(dev, "capabase", 0x100);
> +    qdev_prop_set_uint32(dev, "opregbase", 0x140);

... then drop these lines.

cheers,
  Gerd