From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRN0j-0006RG-P5 for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:58:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRN0c-0005KA-UJ for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:58:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRN0c-0005Jw-J9 for qemu-devel@nongnu.org; Thu, 25 Oct 2012 08:58:02 -0400 Message-ID: <50893752.4060803@redhat.com> Date: Thu, 25 Oct 2012 14:57:54 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <6a52b259a18cf580984ab4263322b60a4c4877a0.1351157627.git.peter.crosthwaite@xilinx.com> <50892BC7.6080400@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 3/8] usb/ehci: seperate out PCIisms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: vineshp@xilinx.com, edgar.iglesias@gmail.com, john.williams@xilinx.com, qemu-devel@nongnu.org, peter.maydell@linaro.org Hi, >> ... then you don't need to fiddle with the versions as the vmstate wire >> format doesn't change then. >> > > Does that work considering you have turned one layer of VMSD into two? > Can it equivocate machines saved with the old all-in-one vmsd with > this new one that is structured in two layers? I'm pretty sure it does as only for top-level vmsd name and version are stuffed into the wire bytestream. For sub-vmsds only the actual fields are written. So moving stuff from the toplevel vmsd into another one which then gets referenced via VMSTATE_STRUCT doesn't change the format. cheers, Gerd