From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRNK5-0001CK-4e for qemu-devel@nongnu.org; Thu, 25 Oct 2012 09:18:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRNJz-0004uD-PC for qemu-devel@nongnu.org; Thu, 25 Oct 2012 09:18:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRNJz-0004u3-Gr for qemu-devel@nongnu.org; Thu, 25 Oct 2012 09:18:03 -0400 Message-ID: <50893C04.3000003@redhat.com> Date: Thu, 25 Oct 2012 15:17:56 +0200 From: Avi Kivity MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 4/8] usb/ehci: Add usb-ehci-sysbus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: vineshp@xilinx.com, Peter Crosthwaite , qemu-devel@nongnu.org, john.williams@xilinx.com, kraxel@redhat.com, edgar.iglesias@gmail.com On 10/25/2012 11:55 AM, Peter Maydell wrote: > On 25 October 2012 10:47, Peter Crosthwaite > wrote: >> +static int usb_ehci_sysbus_initfn(SysBusDevice *dev) >> +{ >> + EHCIItfState *i = FROM_SYSBUS(EHCIItfState, dev); >> + EHCIState *s = &i->ehci; >> + >> + s->dma = g_new(DMAContext, 1); >> + dma_context_init(s->dma, &address_space_memory, NULL, NULL, NULL); > > Assuming Avi doesn't reject it, better to use the dma_context_memory > I introduced in this patch (not yet applied to master): > http://patchwork.ozlabs.org/patch/193550/ > Patch is good, sorry if you were expecting an explicit ack. -- error compiling committee.c: too many arguments to function