From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRTvf-0007gQ-He for qemu-devel@nongnu.org; Thu, 25 Oct 2012 16:21:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRTvd-0006so-3y for qemu-devel@nongnu.org; Thu, 25 Oct 2012 16:21:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRTvc-0006sW-RX for qemu-devel@nongnu.org; Thu, 25 Oct 2012 16:21:21 -0400 Message-ID: <50899A38.5020909@redhat.com> Date: Thu, 25 Oct 2012 13:59:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1351194520-10673-1-git-send-email-lilei@linux.vnet.ibm.com> <1351194520-10673-2-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1351194520-10673-2-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB6A2E2F6792502A062FF495C" Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB6A2E2F6792502A062FF495C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/25/2012 01:48 PM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qemu-char.c | 136 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qemu-config.c | 3 + > qemu-options.hx | 10 ++++ > 3 files changed, 149 insertions(+), 0 deletions(-) >=20 > diff --git a/qemu-char.c b/qemu-char.c > index b082bae..45d2a86 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -99,6 +99,7 @@ > #include "ui/qemu-spice.h" > =20 > #define READ_BUF_LEN 4096 > +#define CBUFF_SIZE 65536 > =20 > /***********************************************************/ > /* character device */ > @@ -2588,6 +2589,130 @@ size_t qemu_chr_mem_osize(const CharDriverState= *chr) > return d->outbuf_size; > } > =20 > +/*********************************************************/ > +/*CircularMemoryr chardev*/ s/CircularMemoryr/CircularMemory/ This typo was pointed out to you in v4; makes me wonder what else you missed while preparing v5. > @@ -1824,6 +1826,14 @@ the console, in pixels. > @option{cols} and @option{rows} specify that the console be sized to f= it a text > console with the given dimensions. > =20 > +@item -chardev memchr ,id=3D@var{id} ,maxcapacity=3D@var{maxcapacity} > + > +Create a circular buffer with fixed size indicated by optionally @opti= on{maxcapacity} > +which will be default 64K if it is not given. > + > +@option{maxcapacity} specify the max capacity of the size of circular = buffer > +want to create. Should be power of 2. s/specify/specifies/ s/want// --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigB6A2E2F6792502A062FF495C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQiZo5AAoJEKeha0olJ0Nqp6kH/2jy5oZdaTRvv5zYA/cSC6Of YBNedOHgll6dXA9sHYFkEEP9HqObq2XdnzU4Dv9ZwOPiwtH27A+5OdsW04k9qec8 6DfUn3B39f/yDBrarHDQtvyHM0mN7nhgZdxTCRroeDCawHbfZPmhW7PcooZnYYPB bIwqFyxlZTTelgDtEgns3APuBM9TE4LQHl3Sde11JYJCJ0iYF6Wgs+eb3mVlyStH g52lEgA6zu/RpEKAYtknzkjobopLZ+ynJZqyb/945n5/F9eNtIPBzqu0lRtS4MbK R0phW6rGqMURCHPY5FW+AgcmAABWkfP33h6CinFqV6g/fHgXMUTIv/wToo2781A= =7wpp -----END PGP SIGNATURE----- --------------enigB6A2E2F6792502A062FF495C--