From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRTg5-0001XH-0m for qemu-devel@nongnu.org; Thu, 25 Oct 2012 16:05:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRTg3-0001pr-Kj for qemu-devel@nongnu.org; Thu, 25 Oct 2012 16:05:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRTg3-0001p4-C8 for qemu-devel@nongnu.org; Thu, 25 Oct 2012 16:05:15 -0400 Message-ID: <50899B74.8060604@redhat.com> Date: Thu, 25 Oct 2012 14:05:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1351194875-10983-1-git-send-email-lilei@linux.vnet.ibm.com> <1351194875-10983-2-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1351194875-10983-2-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF119CA9C96922D71FC75DE43" Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF119CA9C96922D71FC75DE43 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/25/2012 01:54 PM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qemu-char.c | 136 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qemu-config.c | 3 + > qemu-options.hx | 10 ++++ > 3 files changed, 149 insertions(+), 0 deletions(-) >=20 > =20 > +/*********************************************************/ > +/*CircularMemory chardev*/ > + Better; I'll assume the other thread also title v5 was a mis-send. > +Create a circular buffer with fixed size indicated by optionally @opti= on{maxcapacity} > +which will be default 64K if it is not given. > + > +@option{maxcapacity} specify the max capacity of the size of circular = buffer > +want to create. Should be power of 2. Still, this grammar could be improved: s/specify/specifies/ s/want// --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF119CA9C96922D71FC75DE43 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQiZt0AAoJEKeha0olJ0NqWr4H/14lO0HWvXlaHhMwUjwUnY0k eKU56/hV25LXsBiueB5tbaE30s8EgDIQBJFdZ04/WH3H5hA5JU331osTs9IFK/zy Y6sMq3MLDLkeCzrJB/0k91zkbaytPVJT5GXbMN+DmudZVS+QIw9pCeAwDxWzLzrw ID/DWPL98AmQg/kIOWvwI7HQ9kWeqLkGPIEzdNUnBcbOtP5cIDs6G+j8UpjpBg6v c/6a77HbUHeK36w6CbqIIrJaitknLk1ssN/iT2b4tmnu+u/zXvzRyFPKsAWyIgNn Pw76Y+U3e45XrbxKKeHlrI2nJIZW9IvM8Zg6o9S6TwiffeERVsRuntb3/y0Dy+A= =jXi6 -----END PGP SIGNATURE----- --------------enigF119CA9C96922D71FC75DE43--