qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Luiz Capitulino <lcapitulino@redhat.com>, aliguori@us.ibm.com
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] win32: fix broken build due to missing	QEMU_MADV_HUGEPAGE
Date: Thu, 25 Oct 2012 22:24:40 +0200	[thread overview]
Message-ID: <5089A008.8030202@weilnetz.de> (raw)
In-Reply-To: <20121024141215.737e0f2a@doriath.home>

Am 24.10.2012 18:12, schrieb Luiz Capitulino:
> Commit ad0b5321f1f797274603ebbe20108b0750baee94 forgot to add
> QEMU_MADV_HUGEPAGE macros for when CONFIG_MADVISE is not defined.
> This broke the build for Windows. Fix it.
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> ---
>   osdep.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/osdep.h b/osdep.h
> index c5fd3d9..585e2c1 100644
> --- a/osdep.h
> +++ b/osdep.h
> @@ -121,6 +121,7 @@ void qemu_vfree(void *ptr);
>   #define QEMU_MADV_DONTFORK  QEMU_MADV_INVALID
>   #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
>   #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE  QEMU_MADV_INVALID
>
>   #else /* no-op */
>
> @@ -129,6 +130,7 @@ void qemu_vfree(void *ptr);
>   #define QEMU_MADV_DONTFORK  QEMU_MADV_INVALID
>   #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
>   #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE  QEMU_MADV_INVALID
>
>   #endif
>    

Reviewed-by: Stefan Weil <sw@weilnetz.de>

This is a build fix for latest QEMU. Please apply it as soon as possible.

Regards
Stefan Weil

  reply	other threads:[~2012-10-25 20:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 16:12 [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE Luiz Capitulino
2012-10-25 20:24 ` Stefan Weil [this message]
2012-10-26 15:34 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5089A008.8030202@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).