From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRVER-0004s7-Jr for qemu-devel@nongnu.org; Thu, 25 Oct 2012 17:44:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRVEQ-00061A-Kb for qemu-devel@nongnu.org; Thu, 25 Oct 2012 17:44:51 -0400 Received: from hub021-nj-8.exch021.serverdata.net ([206.225.164.233]:25196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRVEQ-000612-GV for qemu-devel@nongnu.org; Thu, 25 Oct 2012 17:44:50 -0400 Message-ID: <5089B2D0.6010703@CloudSwitch.Com> Date: Thu, 25 Oct 2012 17:44:48 -0400 From: Don Slutz MIME-Version: 1.0 References: <1350918203-25198-1-git-send-email-imammedo@redhat.com> <1350918203-25198-19-git-send-email-imammedo@redhat.com> In-Reply-To: <1350918203-25198-19-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 18/37] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de On 10/22/12 11:03, Igor Mammedov wrote: > It's needed for converting hv_* features into properties and to > avoid build breakage when qemu is built with --disable-kvm option. > > Signed-off-by: Igor Mammedov > Reported-by: Eduardo Habkost > --- > target-i386/hyperv.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/target-i386/hyperv.h b/target-i386/hyperv.h > index bacb1d4..7bd4d9e 100644 > --- a/target-i386/hyperv.h > +++ b/target-i386/hyperv.h > @@ -30,16 +30,19 @@ > void hyperv_enable_vapic_recommended(bool val); > void hyperv_enable_relaxed_timing(bool val); > void hyperv_set_spinlock_retries(int val); > +bool hyperv_vapic_recommended(void); > +bool hyperv_relaxed_timing_enabled(void); > +int hyperv_get_spinlock_retries(void); > #else > static inline void hyperv_enable_vapic_recommended(bool val) { } > static inline void hyperv_enable_relaxed_timing(bool val) { } > static inline void hyperv_set_spinlock_retries(int val) { } > +static inline bool hyperv_vapic_recommended(void) { return false; } > +static inline bool hyperv_relaxed_timing_enabled(void) { return false; } > +static inline int hyperv_get_spinlock_retries(void) { return 0; } > #endif > > bool hyperv_enabled(void); > bool hyperv_hypercall_available(void); > -bool hyperv_vapic_recommended(void); > -bool hyperv_relaxed_timing_enabled(void); > -int hyperv_get_spinlock_retries(void); > > #endif /* QEMU_HW_HYPERV_H */ Reviewed-by: Don Slutz