Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

[Lei Li <lilei@linux.vnet.ibm.com>]

On 10/26/2012 04:05 AM, Eric Blake wrote:
> On 10/25/2012 01:54 PM, Lei Li wrote:
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
>> ---
>>   qemu-char.c     |  136 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   qemu-config.c   |    3 +
>>   qemu-options.hx |   10 ++++
>>   3 files changed, 149 insertions(+), 0 deletions(-)
>>
>>   
>> +/*********************************************************/
>> +/*CircularMemory chardev*/
>> +
> Better; I'll assume the other thread also title v5 was a mis-send.
>
Yeah, you are right. Sorry for the mis-sending...  :-[

>> +Create a circular buffer with fixed size indicated by optionally @option{maxcapacity}
>> +which will be default 64K if it is not given.
>> +
>> +@option{maxcapacity} specify the max capacity of the size of circular buffer
>> +want to create. Should be power of 2.
> Still, this grammar could be improved:
>
> s/specify/specifies/
> s/want//

Sure, thanks!



-- 
Lei