From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRbyo-0001Qy-9k for qemu-devel@nongnu.org; Fri, 26 Oct 2012 00:57:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRbyn-0004v7-AB for qemu-devel@nongnu.org; Fri, 26 Oct 2012 00:57:10 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:45583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRbym-0004ue-L0 for qemu-devel@nongnu.org; Fri, 26 Oct 2012 00:57:09 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Oct 2012 10:26:58 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9Q4uuBx38142146 for ; Fri, 26 Oct 2012 10:26:56 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9QAQmea007316 for ; Fri, 26 Oct 2012 10:26:48 GMT Message-ID: <508A17EC.7010307@linux.vnet.ibm.com> Date: Fri, 26 Oct 2012 12:56:12 +0800 From: Lei Li MIME-Version: 1.0 References: <1351194875-10983-1-git-send-email-lilei@linux.vnet.ibm.com> <1351194875-10983-2-git-send-email-lilei@linux.vnet.ibm.com> <50899B74.8060604@redhat.com> In-Reply-To: <50899B74.8060604@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On 10/26/2012 04:05 AM, Eric Blake wrote: > On 10/25/2012 01:54 PM, Lei Li wrote: >> Signed-off-by: Lei Li >> --- >> qemu-char.c | 136 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> qemu-config.c | 3 + >> qemu-options.hx | 10 ++++ >> 3 files changed, 149 insertions(+), 0 deletions(-) >> >> >> +/*********************************************************/ >> +/*CircularMemory chardev*/ >> + > Better; I'll assume the other thread also title v5 was a mis-send. > Yeah, you are right. Sorry for the mis-sending... :-[ >> +Create a circular buffer with fixed size indicated by optionally @option{maxcapacity} >> +which will be default 64K if it is not given. >> + >> +@option{maxcapacity} specify the max capacity of the size of circular buffer >> +want to create. Should be power of 2. > Still, this grammar could be improved: > > s/specify/specifies/ > s/want// Sure, thanks! -- Lei