From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56369)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRdjv-00014f-Eh
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 02:49:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRdju-0007QC-Bl
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 02:49:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21885)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRdju-0007PS-3g
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 02:49:54 -0400
Message-ID: <508A328C.6030604@redhat.com>
Date: Fri, 26 Oct 2012 08:49:48 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1351157627.git.peter.crosthwaite@xilinx.com>
	<e47518863bca237dd485619a6812d5df31ce16db.1351157627.git.peter.crosthwaite@xilinx.com>
	<50892CB0.6020706@redhat.com>
	<CAFEAcA8b=dyG85o2FJ_VFENXV_nJXC=D=bbM7R2KcASXCg8A_A@mail.gmail.com>
	<CAEgOgz7ey4EXFEuVfb3DtDV7RTX8+kQ=d5Yir9icBAfaYN7-Yg@mail.gmail.com>
	<50893B33.5000908@redhat.com>
	<CAEgOgz7K5_BVb+RNXpiW2H3nY1DyS9K68-=j9E5sQEUxADY+NQ@mail.gmail.com>
	<50894360.906@redhat.com> <5089485E.5090004@redhat.com>
	<CAEgOgz4nF2AYHH+bSG7x20bKPUhBOBiVdCGq4beTx8AWf2Nt2w@mail.gmail.com>
	<CAEgOgz7EBRWqpSxHNfJv6Zod4ymmEct98VFMvEmwPwzVrb-CxA@mail.gmail.com>
In-Reply-To: <CAEgOgz7EBRWqpSxHNfJv6Zod4ymmEct98VFMvEmwPwzVrb-CxA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 5/8] xilinx_zynq: add USB controllers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: vineshp@xilinx.com, Peter Maydell <peter.maydell@linaro.org>, john.williams@xilinx.com, qemu-devel@nongnu.org, edgar.iglesias@gmail.com

  Hi,

>> @@ -1312,29 +1320,24 @@ static TypeInfo piix3_uhci_info = {
>>      .name          = "piix3-usb-uhci",
>>      .parent        = TYPE_PCI_DEVICE,
>>      .instance_size = sizeof(UHCIState),
>> -    .class_init    = piix3_uhci_class_init,
>> +    .class_init    = uhci_class_init,
> 
> Therese three elements (parent, instance_size, class_init) are
> repeated from one definition to the next. This will get tedious when
> we eventually come to make the same fix for some of the other devices
> that have large numbers of variants (pflash_cfi0x and m25p80 being
> some of the angrier ones).

I think we can also create TypeInfo at runtime (uhci_register_types in
the uhci case).  We'll just have to stick the name into UHCIInfo, build
a static uhciinfo array, then generate & register TypeInfo from that.

cheers,
  Gerd