From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRibU-0006iz-KJ for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:01:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRibO-0003Xy-9r for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:01:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRibO-0003WL-1d for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:01:26 -0400 Message-ID: <508A7B69.8050003@redhat.com> Date: Fri, 26 Oct 2012 14:00:41 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1351240148-13723-1-git-send-email-mail@sebastianbauer.info> <1351240148-13723-2-git-send-email-mail@sebastianbauer.info> In-Reply-To: <1351240148-13723-2-git-send-email-mail@sebastianbauer.info> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Bauer Cc: qemu-devel@nongnu.org On 10/26/12 10:29, Sebastian Bauer wrote: Wrong fix I think. Just moving "port->portsc |= PORTSC_CSC" out of the "if (running)" should do. usb-next already has a patch which fixes this: http://www.kraxel.org/cgit/qemu/commit/?h=rebase/usb-next&id=84f84686c701731964a515e9bbcfb475cfc1de8c cheers, Gerd