From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55606)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRixm-0003h8-Rb
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:24:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRixi-0001LU-0V
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:24:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22988)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TRixh-0001LQ-Oh
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:24:29 -0400
Message-ID: <508A80F8.7070202@redhat.com>
Date: Fri, 26 Oct 2012 14:24:24 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1351229557.git.peter.crosthwaite@xilinx.com>
	<16ccd8856bbc63649b8d5bed1123213ac0a05edc.1351229557.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <16ccd8856bbc63649b8d5bed1123213ac0a05edc.1351229557.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: vineshp@xilinx.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, john.williams@xilinx.com, edgar.iglesias@gmail.com, afaerber@suse.de

  Hi,

> +typedef struct EHCItfState {
> +    union {
> +        PCIDevice pcidev;
> +    };
> +    struct EHCIState ehci;
> +} EHCIItfState;

I still think we should have EHCIPCIState here, then add a
EHCISysbusState variant for sysbus.  Everybody else does it this way
(ohci, esp, serial, ...) and I'd like ehci follow.  Also makes it easier
to split the source code into core, pci and sysbus pieces, i.e. move all
the pci bits to hcd-ehci-pci.c and compile only for targets with pci
support.

cheers,
  Gerd