From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRizT-0004bX-Ar for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:26:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRizP-000233-FB for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:26:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRizP-00022t-6o for qemu-devel@nongnu.org; Fri, 26 Oct 2012 08:26:15 -0400 Message-ID: <508A815F.7010902@redhat.com> Date: Fri, 26 Oct 2012 14:26:07 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <602c6648fbc0ba72b70cf3223479c6ec7e829a58.1351229557.git.peter.crosthwaite@xilinx.com> In-Reply-To: <602c6648fbc0ba72b70cf3223479c6ec7e829a58.1351229557.git.peter.crosthwaite@xilinx.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 08/11] xilinx_zynq: add USB controllers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: vineshp@xilinx.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, john.williams@xilinx.com, edgar.iglesias@gmail.com, afaerber@suse.de > diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c > index c55dafb..154e397 100644 > --- a/hw/xilinx_zynq.c > +++ b/hw/xilinx_zynq.c > @@ -150,6 +150,9 @@ static void zynq_init(QEMUMachineInitArgs *args) > zynq_init_spi_flashes(0xE0006000, pic[58-IRQ_OFFSET]); > zynq_init_spi_flashes(0xE0007000, pic[81-IRQ_OFFSET]); > > + sysbus_create_simple("xlnx,ps7-usb", 0xE0002000, pic[53-IRQ_OFFSET]); > + sysbus_create_simple("xlnx,ps7-usb", 0xE0003000, pic[75-IRQ_OFFSET]); Nice. Much better than the create-usb helper function setting properties. cheers, Gerd