From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRlqG-0002bP-KW for qemu-devel@nongnu.org; Fri, 26 Oct 2012 11:29:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRlqB-0003z2-6B for qemu-devel@nongnu.org; Fri, 26 Oct 2012 11:29:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRlqA-0003y9-UR for qemu-devel@nongnu.org; Fri, 26 Oct 2012 11:28:55 -0400 Message-ID: <508AAC32.8020705@redhat.com> Date: Fri, 26 Oct 2012 17:28:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <508A9A9E.3090203@redhat.com> <871ugljmev.fsf@codemonkey.ws> In-Reply-To: <871ugljmev.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] virtio-rng: hardware random number generator device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , qemu list Il 26/10/2012 17:14, Anthony Liguori ha scritto: >> > I would instead have the following: >> > >> > - a chardev that can read from a file (e.g. -chardev >> > file,path=/dev/urandom,read=on,id=urandom) > Then your multiplexing lots of logic into the chardev layer. Then call it -chardev filein,path=/dev/urandom,id=urandom. :) > Three of these patches can be dropped. See the series I sent out. Same comments apply there... Paolo