From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Amit Shah <amit.shah@redhat.com>,
qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-rng-pci: create a default backend if none exists
Date: Fri, 26 Oct 2012 22:22:24 +0200 [thread overview]
Message-ID: <508AF100.80007@redhat.com> (raw)
In-Reply-To: <87d305ng42.fsf@codemonkey.ws>
Il 26/10/2012 22:16, Anthony Liguori ha scritto:
> So it's still a failure, just a different message.
>
> But this does suggest that we shouldn't add it to the default machine on
> !Linux because we don't want the default machine failing.
We need to add it to all machines, because the machine signature should
not depend on the host OS. However, it does suggest we need a null
backend as a fallback.
> Perhaps we can find better default backends on !Linux...
Yes, rdrand would be one.
>> > What if the default was changed to /dev/hwrng but an older Linux
>> > distro didn't have the device file at all?
> It would throw an error gracefully.
Perhaps the default backend can be created with a function that tries
multiple things and at worst settles on rng-null.
Paolo
next prev parent reply other threads:[~2012-10-26 20:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 17:21 [Qemu-devel] [PATCH 0/4] Enable virtio-{rng,balloon} by default Anthony Liguori
2012-10-26 17:21 ` [Qemu-devel] [PATCH 1/4] rng-random: split out header for rng-random Anthony Liguori
2012-10-26 17:21 ` [Qemu-devel] [PATCH 2/4] virtio-rng-pci: create a default backend if none exists Anthony Liguori
2012-10-26 18:59 ` Paolo Bonzini
2012-10-26 19:51 ` Anthony Liguori
2012-10-26 20:20 ` Paolo Bonzini
2012-10-26 19:53 ` Paolo Bonzini
2012-10-26 20:16 ` Anthony Liguori
2012-10-26 20:22 ` Paolo Bonzini [this message]
2012-10-26 17:21 ` [Qemu-devel] [PATCH 3/4] machine: add default_devices field to QEMUMachine Anthony Liguori
2012-11-05 12:27 ` Markus Armbruster
2012-10-26 17:21 ` [Qemu-devel] [PATCH 4/4] pc-1.3: add virtio-rng and virtio-balloon to the default machine Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508AF100.80007@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).