From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TRqQF-0008EF-Tp
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 16:22:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TRqQE-0007rA-W7
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 16:22:27 -0400
Received: from mail-ee0-f45.google.com ([74.125.83.45]:40161)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TRqQE-0007r4-O1
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 16:22:26 -0400
Received: by mail-ee0-f45.google.com with SMTP id b47so1340204eek.4
	for <qemu-devel@nongnu.org>; Fri, 26 Oct 2012 13:22:26 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <508AF100.80007@redhat.com>
Date: Fri, 26 Oct 2012 22:22:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1351272088-7942-1-git-send-email-aliguori@us.ibm.com>
	<1351272088-7942-3-git-send-email-aliguori@us.ibm.com>
	<508ADDAA.7070205@redhat.com> <508AEA4E.5080202@redhat.com>
	<87d305ng42.fsf@codemonkey.ws>
In-Reply-To: <87d305ng42.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-rng-pci: create a default
 backend if none exists
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>

Il 26/10/2012 22:16, Anthony Liguori ha scritto:
> So it's still a failure, just a different message.
> 
> But this does suggest that we shouldn't add it to the default machine on
> !Linux because we don't want the default machine failing.

We need to add it to all machines, because the machine signature should
not depend on the host OS.  However, it does suggest we need a null
backend as a fallback.

> Perhaps we can find better default backends on !Linux...

Yes, rdrand would be one.

>> > What if the default was changed to /dev/hwrng but an older Linux
>> > distro didn't have the device file at all?
> It would throw an error gracefully.

Perhaps the default backend can be created with a function that tries
multiple things and at worst settles on rng-null.

Paolo