From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TSUQc-00068Q-Bl
	for qemu-devel@nongnu.org; Sun, 28 Oct 2012 11:05:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TSUQb-00063L-Fi
	for qemu-devel@nongnu.org; Sun, 28 Oct 2012 11:05:30 -0400
Received: from mail-ee0-f45.google.com ([74.125.83.45]:45848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TSUQb-00062w-9N
	for qemu-devel@nongnu.org; Sun, 28 Oct 2012 11:05:29 -0400
Received: by mail-ee0-f45.google.com with SMTP id b47so1879030eek.4
	for <qemu-devel@nongnu.org>; Sun, 28 Oct 2012 08:05:27 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <508D49B3.20008@redhat.com>
Date: Sun, 28 Oct 2012 16:05:23 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1350555758-29988-1-git-send-email-pbonzini@redhat.com>
	<1350555758-29988-7-git-send-email-pbonzini@redhat.com>
	<508CFF2F.9060400@redhat.com>
In-Reply-To: <508CFF2F.9060400@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/12] migration: use migrate_fd_close in
	migrate_fd_cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Orit Wasserman <owasserm@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

Il 28/10/2012 10:47, Orit Wasserman ha scritto:
>> >      if (s->file) {
>> >          DPRINTF("closing file\n");
>> >          ret = qemu_fclose(s->file);
>> > -        s->file = NULL;
> why remove this line?

Good catch.

Paolo