From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TT681-00045M-93 for qemu-devel@nongnu.org; Tue, 30 Oct 2012 03:20:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TT67z-0007HR-Qa for qemu-devel@nongnu.org; Tue, 30 Oct 2012 03:20:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TT67z-0007H7-Iz for qemu-devel@nongnu.org; Tue, 30 Oct 2012 03:20:47 -0400 Message-ID: <508F7FC6.1060608@redhat.com> Date: Tue, 30 Oct 2012 08:20:38 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/8] Sysbus EHCI + Zynq USB. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: vineshp@xilinx.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, john.williams@xilinx.com, edgar.iglesias@gmail.com, =?ISO-8859-1?Q?Andreas_F=E4rber?= On 10/29/12 15:08, Peter Crosthwaite wrote: > Ping! > > This is the first version of the EHCI sysbus series which takes a > property based approach rather than the dynamic class approach. > > No refactoring of the PCI stuff is done here (introduced v2) but > following on from the discussion on IRC about how to do and the > suggestion we take a property based approach, could we get a review of > this and mix and match between this and V3 for the solution? I like the EHCI{Pci,Sysbus}State approach in the v3 series, also the sysbus restruction so sysbus_create_simple() can be used in v2+. I'd suggest to drop all the controversial stuff: - v3 patch #1 (go with NULL like ohci does for the time being, when we finally figured+agreed on how to fix it we can change both ehci+ohci). - v3 patch #2 (class_data for pci). With patch #2 being gone patch #6 needs to be changed too of course. Just do it the classic way for now and lets worry later about how to dynamically generate variants. Have you tested the patch for the unmapped-register access I've sent? cheers, Gerd