From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTCK4-0007Iu-9o for qemu-devel@nongnu.org; Tue, 30 Oct 2012 09:57:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTCJa-0004KP-Vg for qemu-devel@nongnu.org; Tue, 30 Oct 2012 09:57:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTCJa-0004K7-LD for qemu-devel@nongnu.org; Tue, 30 Oct 2012 09:57:10 -0400 Message-ID: <508FDCAC.7060502@redhat.com> Date: Tue, 30 Oct 2012 15:57:00 +0200 From: Avi Kivity MIME-Version: 1.0 References: <508FA30A.4040308@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: vineshp@xilinx.com, Peter Maydell , i.mitsyanko@samsung.com, qemu-devel@nongnu.org, Kirill Batuzov , john.williams@xilinx.com, edgar.iglesias@gmail.com, afaerber@suse.de On 10/30/2012 03:42 PM, Peter Crosthwaite wrote: > On Tue, Oct 30, 2012 at 7:51 PM, Avi Kivity wrote: >> On 10/29/2012 10:32 AM, Peter Maydell wrote: >>> On 29 October 2012 06:35, Peter Crosthwaite >>> wrote: >>>> Device model for Primecell PL330 dma controller. >>> >>> A general question -- this is a DMA controller so should it be using >>> the DMAContext APIs now? Avi? >> >> IOMMU functionality will be folded into the memory core, so >> address_space_rw() and family. >> >> > > Hi Avi, > > So does this mean no more dma_contexts and dma_memory_foo? Correct. > I have > remade the series (and others) using dma_memory_*. Can you point to a > sysbus attached DMA controller currently in tree that does it properly > so we can use it for a basis as there are several (four in total > think) series I have pending all containing DMA which will be effected > by this. I don't think there are any. If your dma controller does not have an IOMMU, all you need to do is replace cpu_physical_memory_*(...) with address_space_*(&address_space_memory, ...). If it does have an IOMMU, then you need to wait until my IOMMU patchset hits mainline (or use DMAContext). -- error compiling committee.c: too many arguments to function