From: Cole Robinson <crobinso@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] arm_boot: Change initrd load address to "halfway through RAM"
Date: Tue, 30 Oct 2012 10:56:46 -0400 [thread overview]
Message-ID: <508FEAAE.6030702@redhat.com> (raw)
In-Reply-To: <1351265378-13866-1-git-send-email-peter.maydell@linaro.org>
On 10/26/2012 11:29 AM, Peter Maydell wrote:
> To avoid continually having to bump the initrd load address
> to account for larger kernel images, put the initrd halfway
> through RAM. This allows large kernels on new boards with lots
> of RAM to work OK, without breaking existing usecases for
> boards with only 32MB of RAM.
>
> Note that this change fixes in passing a bug where we were
> passing an overly large max_size to load_image_targphys()
> for the initrd, which meant that we wouldn't correctly refuse
> to load an enormous initrd that didn't actually fit into RAM.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Changes v1->v2: put initrd at min(128M, ram_size / 2)
> rather than just at ram_size / 2.
I confirmed this patch fixes the original problem reported here:
https://bugzilla.redhat.com/show_bug.cgi?id=862766
Thanks Peter!
Tested-by: Cole Robinson <crobinso@redhat.com>
Thanks,
Cole
next prev parent reply other threads:[~2012-10-30 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 15:29 [Qemu-devel] [PATCH v2] arm_boot: Change initrd load address to "halfway through RAM" Peter Maydell
2012-10-29 13:54 ` Aurelien Jarno
2012-10-30 13:56 ` Igor Mitsyanko
2012-10-30 14:56 ` Cole Robinson [this message]
2012-11-01 16:05 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508FEAAE.6030702@redhat.com \
--to=crobinso@redhat.com \
--cc=patches@linaro.org \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).