From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1TTDFP-0005g6-Qh
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 10:57:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1TTDFK-0006Jh-3P
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 10:56:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1TTDFJ-0006JJ-R4
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 10:56:50 -0400
Message-ID: <508FEAAE.6030702@redhat.com>
Date: Tue, 30 Oct 2012 10:56:46 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <1351265378-13866-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1351265378-13866-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] arm_boot: Change initrd load address to
 "halfway through RAM"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>, qemu-devel@nongnu.org, patches@linaro.org

On 10/26/2012 11:29 AM, Peter Maydell wrote:
> To avoid continually having to bump the initrd load address
> to account for larger kernel images, put the initrd halfway
> through RAM. This allows large kernels on new boards with lots
> of RAM to work OK, without breaking existing usecases for
> boards with only 32MB of RAM.
> 
> Note that this change fixes in passing a bug where we were
> passing an overly large max_size to load_image_targphys()
> for the initrd, which meant that we wouldn't correctly refuse
> to load an enormous initrd that didn't actually fit into RAM.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Changes v1->v2: put initrd at min(128M, ram_size / 2)
> rather than just at ram_size / 2.

I confirmed this patch fixes the original problem reported here:

https://bugzilla.redhat.com/show_bug.cgi?id=862766

Thanks Peter!

Tested-by: Cole Robinson <crobinso@redhat.com>

Thanks,
Cole