From: Richard Henderson <rth@twiddle.net>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/7] target-alpha: Turn CPU definitions into subclasses
Date: Wed, 31 Oct 2012 15:57:43 +1100 [thread overview]
Message-ID: <5090AFC7.7010107@twiddle.net> (raw)
In-Reply-To: <1351652644-18687-3-git-send-email-afaerber@suse.de>
On 2012-10-31 14:03, Andreas Färber wrote:
> +static const AlphaCPUInfo alpha_cpus[] = {
> + { .name = "ev4", .initfn = ev4_cpu_initfn },
> + { .name = "ev5", .initfn = ev5_cpu_initfn },
> + { .name = "ev56", .initfn = ev56_cpu_initfn },
> + { .name = "pca56", .initfn = pca56_cpu_initfn },
> + { .name = "ev6", .initfn = ev6_cpu_initfn },
> + { .name = "ev67", .initfn = ev67_cpu_initfn },
> + { .name = "ev68", .initfn = ev68_cpu_initfn },
> + { .name = "21064", .initfn = alpha_21064_cpu_initfn },
> + { .name = "21164", .initfn = alpha_21164_cpu_initfn },
> + { .name = "21164a", .initfn = alpha_21164a_cpu_initfn },
> + { .name = "21164pc", .initfn = alpha_21164pc_cpu_initfn },
> + { .name = "21264", .initfn = alpha_21264_cpu_initfn },
> + { .name = "21264a", .initfn = alpha_21264a_cpu_initfn },
> +};
The "2*" names are aliases of the "ev*" names. There's no need for so
much duplication. And for that matter, "ev68" is no different from "ev67"
at the level for which we emulate. In hw, it was more cache and a faster
multiply implementation.
r~
next prev parent reply other threads:[~2012-10-31 4:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 3:03 [Qemu-devel] [PATCH 0/7] target-alpha: More CPU QOM'ifications Andreas Färber
2012-10-31 3:03 ` [Qemu-devel] [FYI 1/7] target-alpha: Use consistent include paths Andreas Färber
2012-10-31 3:03 ` [Qemu-devel] [PATCH 2/7] target-alpha: Turn CPU definitions into subclasses Andreas Färber
2012-10-31 4:57 ` Richard Henderson [this message]
2012-12-06 10:11 ` Andreas Färber
2012-12-07 13:58 ` Richard Henderson
2012-12-06 15:29 ` Eduardo Habkost
2012-12-06 15:51 ` Andreas Färber
2012-12-06 16:09 ` Eduardo Habkost
2012-12-06 16:21 ` Andreas Färber
2012-10-31 3:04 ` [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ? Andreas Färber
2012-10-31 5:01 ` Richard Henderson
2012-12-06 15:37 ` Eduardo Habkost
2012-12-06 15:42 ` Andreas Färber
2012-12-06 16:02 ` Andreas Färber
2012-12-06 17:45 ` Eduardo Habkost
2012-12-06 15:59 ` Peter Maydell
2012-12-06 16:10 ` Eduardo Habkost
2012-10-31 3:04 ` [Qemu-devel] [PATCH 4/7] target-alpha: Let cpu_alpha_init() return AlphaCPU Andreas Färber
2012-10-31 5:02 ` Richard Henderson
2012-10-31 3:04 ` [Qemu-devel] [PATCH 5/7] alpha: Pass AlphaCPU array to Typhoon Andreas Färber
2012-10-31 5:04 ` Richard Henderson
2012-10-31 3:04 ` [Qemu-devel] [PATCH 6/7] target-alpha: Avoid leaking the alarm timer over reset Andreas Färber
2012-10-31 5:08 ` Richard Henderson
2012-10-31 3:04 ` [Qemu-devel] [RFC 7/7] target-alpha: Implement CPU reset Andreas Färber
2012-10-31 5:10 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5090AFC7.7010107@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).