From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TTQZl-0004Zh-Oc
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 01:10:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TTQZj-0004Fi-2T
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 01:10:49 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:38451)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TTQZi-0004FZ-KC
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 01:10:46 -0400
Received: by mail-pb0-f45.google.com with SMTP id rp2so680197pbb.4
	for <qemu-devel@nongnu.org>; Tue, 30 Oct 2012 22:10:45 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5090B2D2.9070807@twiddle.net>
Date: Wed, 31 Oct 2012 16:10:42 +1100
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1351652644-18687-1-git-send-email-afaerber@suse.de>
	<1351652644-18687-8-git-send-email-afaerber@suse.de>
In-Reply-To: <1351652644-18687-8-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC 7/7] target-alpha: Implement CPU reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On 2012-10-31 14:04, Andreas Färber wrote:
> +/* CPUClass::reset() */
> +static void alpha_cpu_reset(CPUState *s)
> +{
> +    AlphaCPU *cpu = ALPHA_CPU(s);
> +    AlphaCPUClass *acc = ALPHA_CPU_GET_CLASS(cpu);
> +    CPUAlphaState *env = &cpu->env;
> +
> +    if (qemu_loglevel_mask(CPU_LOG_RESET)) {
> +        qemu_log("CPU Reset (CPU %d)\n", env->cpu_index);
> +        log_cpu_state(env, 0);
> +    }
> +
> +    acc->parent_reset(s);
> +
> +    memset(env, 0, offsetof(CPUAlphaState, breakpoints));
> +    tlb_flush(env, 1);
> +}

Does this somehow reset the alarm_timer as well?  I'd sort of known about its
unfortunate position and resetting problems before, but I'd been ignoring it.

As for whether this works... I'd be surprised if the bios I wrote needs nothing
else for it to handle reset itself...


r~