From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTVcU-0007dl-6e for qemu-devel@nongnu.org; Wed, 31 Oct 2012 06:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTVcP-00049w-4k for qemu-devel@nongnu.org; Wed, 31 Oct 2012 06:33:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTVcO-00047x-Sa for qemu-devel@nongnu.org; Wed, 31 Oct 2012 06:33:53 -0400 Message-ID: <5090FE86.6040902@redhat.com> Date: Wed, 31 Oct 2012 12:33:42 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1351597670-23031-1-git-send-email-avi@redhat.com> <1351597670-23031-5-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/7] memory: provide a MemoryRegion for IOMMUs to log faults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Alexander Graf , Alex Williamson , Anthony Liguori On 10/30/2012 09:14 PM, Blue Swirl wrote: > On Tue, Oct 30, 2012 at 11:47 AM, Avi Kivity wrote: >> Accesses which do not translate will hit the fault region, which >> can then log the access. > > Maybe special casing the fault region should be avoided, the IOMMU > could set up suitable fault regions by itself. How can it? Please elaborate. I'm not too pleased with using a MemoryRegion for faults, perhaps a MemoryRegionIOMMUOps::fault() callback would be better. -- error compiling committee.c: too many arguments to function