From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47478 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBZpx-0002ez-5k for qemu-devel@nongnu.org; Mon, 10 May 2010 16:44:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBZpq-0004hy-So for qemu-devel@nongnu.org; Mon, 10 May 2010 16:44:23 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:43623) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBZpq-0004hM-8u for qemu-devel@nongnu.org; Mon, 10 May 2010 16:44:18 -0400 In-Reply-To: <1273522353-12851-1-git-send-email-weil@mail.berlios.de> From: "=?utf-8?q?Fran=C3=A7ois?= Revol" Date: Mon, 10 May 2010 22:44:07 +0200 CEST Message-Id: <509116712-BeMail@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: kwolf@redhat.com, qemu-devel@nongnu.org Le Mon, 10 May 2010 22:12:33 +0200, Stefan Weil a =C3=A9crit : > The fix is based on a patch from Kevin Wolf. Here his comment: > > "The number of blocks needs to be rounded up to cover all of the > virtual hard > disk. Without this fix, we can't even open our own images if their > size is not > a multiple of the block size." > > While Kevin's patch addressed vdi=5Fcreate, my modification also fixes > vdi=5Fopen which now accepts images with odd disk sizes as well as > images created with old versions of qemu-img. > > Cc: Kevin Wolf > Cc: Fran=C3=A7ois Revol Looks good to me on first read. Fran=C3=A7ois.