From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTXV0-0001Xi-Vp for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:34:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTXUv-0002EQ-6H for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:34:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTXUu-0002EM-UC for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:34:17 -0400 Message-ID: <50911ABA.4050003@redhat.com> Date: Wed, 31 Oct 2012 14:34:02 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1348226255-4226-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1348226255-4226-6-git-send-email-vasilis.liaskovitis@profitbricks.com> <20121023122532.GE19977@stefanha-thinkpad.redhat.com> <50910848.7000002@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v3 05/19] Implement dimm device abstraction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: blauwirbel@gmail.com, kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org, liu ping fan , qemu-devel@nongnu.org, Vasilis Liaskovitis , kevin@koconnor.net, kraxel@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com, Paolo Bonzini On 10/31/2012 02:18 PM, Stefan Hajnoczi wrote: >> >> IMO we should use the same mechanism as proposed for other devices: >> address_space_map() should grab a reference on the dimm device, and >> address_space_unmap() can release it. This way device destruction will >> be deferred as soon as all devices complete I/O. >> >> We will have to be careful with network receive buffers though, since >> they can be held indefinitely. > > Network receive buffers aren't mapped. Net receive is not zero-copy. > For example, virtio-net does virtqueue_pop() inside > virtio_net_receive(). > > I don't see a problem with networking. What about vhost-net? But that is managed separately with a MemoryListener. -- error compiling committee.c: too many arguments to function