From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49802)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TTXtQ-0003j1-UA
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:59:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TTXtP-0002BS-SH
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:59:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TTXtP-0002BL-Jj
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:59:35 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9VCxYHT023419
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 31 Oct 2012 08:59:34 -0400
Message-ID: <50912121.5010707@redhat.com>
Date: Wed, 31 Oct 2012 14:01:21 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1350569156-2565-1-git-send-email-hdegoede@redhat.com>
	<1350569156-2565-2-git-send-email-hdegoede@redhat.com>
	<50811695.7010400@redhat.com>
In-Reply-To: <50811695.7010400@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] usb: split packet result into
	actual_length + status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Hi,

On 10/19/2012 11:00 AM, Gerd Hoffmann wrote:
>    Hi,
>
>> This patch unfortunately is somewhat invasive, since makeing the qemu
>> usb core deal with this requires changes everywhere. This patch only
>> prepares the usb core for this, all the hcd / device changes are done
>> in such a way that there are no functional changes.
>
> /me likes it.
>
> When touching this _anyway_:  How about making usb_handle_packet and
> ->handle_data callbacks return void (or bool for completed/async) and
> expect drivers to fill the fields in USBPacket instead?  That would kill
> a little annonying difference in sync/async packet handling.

Ok, I've redone the patchset making usb_handle_packet and
the device's handle_control and handle_data methods return void, to
make the sync/async packet handling more alike.

This turned out to be quite a bit of work! But is all done now,
and it has been thoroughly tested (although with a subset
of all supported / emulated qemu usb devices, see the
commit message).

Regards,

Hans